Thread (27 messages) 27 messages, 6 authors, 2019-04-04

Re: [RESEND PATCH v6 04/11] dt-bindings: input: add DT bindings for max77650

From: Pavel Machek <hidden>
Date: 2019-03-22 09:09:32
Also in: linux-devicetree, linux-gpio, linux-leds, linux-pm, lkml

On Mon 2019-03-18 18:42:21, Bartosz Golaszewski wrote:
From: Bartosz Golaszewski <redacted>

Add the DT binding document for the onkey module of max77650.

Signed-off-by: Bartosz Golaszewski <redacted>
Reviewed-by: Rob Herring <robh@kernel.org>
+	onkey {
+		compatible = "maxim,max77650-onkey";
+		linux,code = <KEY_END>;
+		maxim,onkey-slide;
+	};
This is certainly wrong.

"End" key is normal key on a keyboard, certainly not some kind of
slider.

And this controller is likely to be used for power key, not end key,
right?

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help