On Fri, Sep 21, 2018 at 04:33:36PM -0700, Dmitry Torokhov wrote:

On Thu, Sep 20, 2018 at 01:16:48PM +0300, Heikki Krogerus wrote:

quoted

On Wed, Sep 19, 2018 at 10:13:26AM -0700, Dmitry Torokhov wrote:

quoted

quoted

quoted

diff --git a/drivers/base/pset_property.c b/drivers/base/pset_property.c
index 08ecc13080ae..63f2377aefe8 100644
--- a/drivers/base/pset_property.c
+++ b/drivers/base/pset_property.c

@@ -18,6 +18,11 @@ struct property_set {
 	struct device *dev;
 	struct fwnode_handle fwnode;
 	const struct property_entry *properties;
+
+	struct property_set *parent;
+	/* Entry in parent->children list */
+	struct list_head child_node;
+	struct list_head children;

Add

        const char *name;

and you can implement also pset_get_named_child_node().

Or
	char name[];

to avoid separate allocation.

Let's not do that, especially if you are planning on exporting this
structure.

Can you please elaborate why? Not using pointer saves us 4/8 bytes +
however much memory we need for bookkeeping for the extra chunk. Given
that majority of pset nodes are unnamed this seems wasteful.

quoted

If the name is coming from .rodata, there is no need to
allocate anything for the name. Check kstrdup_const().

The data is most likely coming as __initconst so we do need to copy it.

OK, I did not consider that. Yes, it makes sense to always copy.

Thanks,

-- 
heikki