Re: [RFC/PATCH 0/5] Support children for legacy device properties
From: Linus Walleij <hidden>
Date: 2018-09-19 19:55:30
Also in:
linux-gpio, lkml
From: Linus Walleij <hidden>
Date: 2018-09-19 19:55:30
Also in:
linux-gpio, lkml
On Mon, Sep 17, 2018 at 11:16 AM Dmitry Torokhov [off-list ref] wrote:
The generic device properties APIs are very helpful as they allow abstracting away details of the platform (whether it is ACPI, device tree, or legacy board file), so that individual driver does not need separate code paths to support all variants. However there are drivers that currently can not use generic device properties API as they need notion of children properties, for example gpio_keys driver, that expects every button to be described as a sub-node of main device. This patch series introduces notion of sub-nodes for static properties and ties it up with GPIO lookup tables so that they are usable with sub-nodes as well.
This is the patch series I would have written, had I been smart enough. Reviewed-by: Linus Walleij <redacted> for the series. I can't test the SIM.ONE board with this until next week but the approach is definately what we want, not just for legacy boards, but also for any other non-discoverable hardware we currently poke into drivers/platform or arch/x86/platform etc. Yours, Linus Walleij Yours, Linus Walleij