Re: [PATCH 1/5] arm: dts: sun8i: a83t: Add I2C0 node
From: Maxime Ripard <hidden>
Date: 2017-12-11 07:15:18
Also in:
linux-arm-kernel, linux-devicetree, lkml
Hi, On Fri, Dec 08, 2017 at 10:54:15PM +0100, Mylène Josserand wrote:
quoted hunk ↗ jump to hunk
Add I2C0 node for A83T. Signed-off-by: Mylène Josserand <mylene.josserand-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> --- arch/arm/boot/dts/sun8i-a83t.dtsi | 11 +++++++++++ 1 file changed, 11 insertions(+)diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi index 19acae1b4089..848cf3f19962 100644 --- a/arch/arm/boot/dts/sun8i-a83t.dtsi +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi@@ -177,6 +177,17 @@ #dma-cells = <1>; }; + i2c0: i2c@01c2ac00 {
Drop the leading 0, it generates a warning in dtc.
+ compatible = "allwinner,sun6i-a31-i2c";
Can you add a SoC-specific compatible there please?
+ reg = <0x01c2ac00 0x400>;
And you should order your nodes by physical address. Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
Attachments
- signature.asc [application/pgp-signature] 833 bytes