Thread (13 messages) 13 messages, 4 authors, 2017-12-11

[PATCH 1/5] arm: dts: sun8i: a83t: Add I2C0 node

From: Maxime Ripard <hidden>
Date: 2017-12-11 07:15:18
Also in: linux-devicetree, linux-input, lkml

Hi,

On Fri, Dec 08, 2017 at 10:54:15PM +0100, Myl?ne Josserand wrote:
quoted hunk ↗ jump to hunk
Add I2C0 node for A83T.

Signed-off-by: Myl?ne Josserand <redacted>
---
 arch/arm/boot/dts/sun8i-a83t.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)
diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi
index 19acae1b4089..848cf3f19962 100644
--- a/arch/arm/boot/dts/sun8i-a83t.dtsi
+++ b/arch/arm/boot/dts/sun8i-a83t.dtsi
@@ -177,6 +177,17 @@
 			#dma-cells = <1>;
 		};
 
+		i2c0: i2c at 01c2ac00 {
Drop the leading 0, it generates a warning in dtc.
+			compatible = "allwinner,sun6i-a31-i2c";
Can you add a SoC-specific compatible there please?
+			reg = <0x01c2ac00 0x400>;
And you should order your nodes by physical address.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20171211/14d2f804/attachment.sig>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help