Re: [PATCH v4 4/4] HID: multitouch: Combine all left-button events in a frame
From: Hans de Goede <hidden>
Date: 2017-11-22 14:01:48
Hi, On 22-11-17 14:59, Benjamin Tissoires wrote:
On Nov 22 2017 or thereabouts, Hans de Goede wrote:quoted
Hi, On 22-11-17 14:37, Jiri Kosina wrote:quoted
On Wed, 22 Nov 2017, Hans de Goede wrote:quoted
quoted
Thanks. Hans, last request for you -- HID_DG_SCANTIME handling has in the meantime added for forwarding the MSC_TIMESTAMP (commit 29cc309d8bf1). Could you please respin your patch on top of that (basically just merge your handling with the one added for MSC_TIMESTAMP) and resend? I'll then queue it for 4.16. Thanks,Ok, v5 with this fixed coming up.Thanks a lot Hans.quoted
Since this fixes 2 touchpad models not working (not being usable at least) it would be nice to get this series into 4.15 rc2/rc3 as a bugfix IMHO.Hmm, as this is changing common code paths, I'd prefer not to push it before next merge window really.I understand, although we are still pre-rc1, so if you queue this up for rc2 we won't miss a lot of the testing window, and I don't think a lot of people with hid-mt touchpads are running -next... Benjamin, what is your take on this?Well, I think both arguments are valid. I would think the patch series is safe, but we never know. How about we schedule this for 4.16 and get it merged in Fedora 27/rawhide soon, so it gets the testings you want but is still scheduled upstream?
You mean add it to the 4.15 kernels in rawhide? That would work for me. Regards, Hans