Hi,

On 21-11-17 13:11, Jiri Kosina wrote:

On Tue, 14 Nov 2017, Benjamin Tissoires wrote:

quoted

quoted

According to the Win8 Precision Touchpad spec, inside the HID_UP_BUTTON
usage-page usage 1 is for a clickpad getting clicked, 2 for an external
left button and 3 for an external right button. Since Linux uses
BTN_LEFT for a clickpad being clicked we end up mapping both usage 1
and 2 to BTN_LEFT and if a single report contains both then we ended
up always reporting the value of both in a single SYN, e.g. :
BTN_LEFT 1, BTN_LEFT 0, SYN. This happens for example with Hantick
HTT5288 i2c mt touchpads.

This commit fixes this by not immediately reporting left button when we
parse the report, but instead storing or-ing together the values and
reporting the result from mt_sync_frame() when we've a complete frame.

Signed-off-by: Hans de Goede <redacted>
---

Thanks Hans for the re-spin of the series.
I think we are good now, series is:

Reviewed-by: Benjamin Tissoires <redacted>

Thanks. Hans, last request for you -- HID_DG_SCANTIME handling has in the
meantime added for forwarding the MSC_TIMESTAMP (commit 29cc309d8bf1).
Could you please respin your patch on top of that (basically just merge
your handling with the one added for MSC_TIMESTAMP) and resend? I'll then
queue it for 4.16. Thanks,

Ok, v5 with this fixed coming up.

Since this fixes 2 touchpad models not working (not being usable at
least) it would be nice to get this series into 4.15 rc2/rc3 as a
bugfix IMHO.

Regards,

Hans