Thread (7 messages) 7 messages, 3 authors, 2017-06-29

Re: [PATCHv3 4/4] hwmon: da9052: add support for TSI channel

From: Guenter Roeck <linux@roeck-us.net>
Date: 2017-06-29 22:45:03
Also in: linux-devicetree, linux-hwmon, lkml

On Thu, Jun 29, 2017 at 11:45:21AM -0700, Dmitry Torokhov wrote:
Hi Sebastian,

On Thu, Jun 29, 2017 at 02:43:46PM +0200, Sebastian Reichel wrote:
quoted
@@ -238,6 +239,14 @@ static int da9052_ts_probe(struct platform_device *pdev)
 	if (!da9052)
 		return -EINVAL;
 
+	/*
+	 * Check if touchscreen pins are used are analogue input instead
+	 * of having a touchscreen connected to them. The analogue input
+	 * functionality will be provided by hwmon driver (if enabled).
+	 */
+	if (device_property_read_bool(pdev->dev.parent, "dlg,tsi-as-adc"))
+		return -ENODEV;
+
I believe this is not the right way of doing this. da9052-core should
simply forgo creating da9052-tsi platform device when this property is
present.
Agreed.

Guenter
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help