Re: [PATCHv3 4/4] hwmon: da9052: add support for TSI channel
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2017-06-29 18:45:33
Also in:
linux-devicetree, linux-hwmon, lkml
Hi Sebastian, On Thu, Jun 29, 2017 at 02:43:46PM +0200, Sebastian Reichel wrote:
quoted hunk ↗ jump to hunk
@@ -238,6 +239,14 @@ static int da9052_ts_probe(struct platform_device *pdev) if (!da9052) return -EINVAL; + /* + * Check if touchscreen pins are used are analogue input instead + * of having a touchscreen connected to them. The analogue input + * functionality will be provided by hwmon driver (if enabled). + */ + if (device_property_read_bool(pdev->dev.parent, "dlg,tsi-as-adc")) + return -ENODEV; +
I believe this is not the right way of doing this. da9052-core should simply forgo creating da9052-tsi platform device when this property is present. Thanks. -- Dmitry