Thread (17 messages) 17 messages, 5 authors, 2017-03-16

Re: [PATCH v1 1/4] gpio: acpi: Don't return 0 on acpi_gpio_count()

From: Linus Walleij <hidden>
Date: 2017-03-16 14:44:21
Also in: linux-gpio, lkml, platform-driver-x86

On Mon, Feb 20, 2017 at 5:15 PM, Andy Shevchenko
[off-list ref] wrote:
It's unusual to have error checking like (ret <= 0) in cases when
counting GPIO resources. In case when it's mandatory we propagate the
error (-ENOENT), otherwise we don't use the result.

This makes consistent behaviour across all possible variants called in
gpiod_count().

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Patch applied with Mika's ACK.

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help