On Fri, Mar 10, 2017 at 10:10:30AM -0800, Dmitry Torokhov wrote:

On Fri, Mar 10, 2017 at 07:04:22PM +0100, Benjamin Tissoires wrote:

quoted

On Mar 10 2017 or thereabouts, Dmitry Torokhov wrote:

quoted

On Fri, Mar 10, 2017 at 04:57:35PM +0100, Benjamin Tissoires wrote:

quoted

Hi Dmitry,

On Mar 09 2017 or thereabouts, Dmitry Torokhov wrote:

quoted

Hi,

This is refresh of Benjamin's patches trying to bridge PS/2 and SMbus
devices for better support of Synaptics RMI4 touchpads (and Elans later).

Thanks!

I have some issues/comments and am still working on those. Here are some
general comments:

quoted

The main difference is that we do not have platform device, as it only
adds another indirection level, and have psmouse create SMBus companion

The purpose of having the platform device was to not have dependency
between psmouse and I2C. Right now I think that patch 6/8 will fail to
compile if I2C=m and PSMOUSE=y (I may be wrong).

This is taken care by the following guards in users if MOUSE_PS2_SMBUS:

depends on I2C=y || I2C=MOUSE_PS2

I can see this guards for MOUSE_PS2_SYNAPTICS_SMBUS, but not for
MOUSE_PS2_SMBUS. So unless I am completely missing the point, if users
disable SYNAPTICS_SMBUS but keep PS2_SMBUS there might be a problem.

Hmm, I'll need to play with this. MOUSE_PS2_SMBUS is not user visible.
Might end up adding condition there as well, or doing somethign more
elaborate, like Arnd did for RMI_F03_SERIO.

So if I disable MOUSE_PS2_SYNAPTICS_SMBUS then MOUSE_PS2_SMBUS
disappears from .config, so I think we are good.

Thanks.

-- 
Dmitry