Re: [PATCH 1/8] i2c: export i2c_client_type structure

From
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date
2017-03-09 23:46:30
Also in
lkml
Reply to
Wolfram Sang, 2017-03-09
On Fri, Mar 10, 2017 at 12:12:46AM +0100, Wolfram Sang wrote:
Dmitry,

On Thu, Mar 09, 2017 at 02:16:37PM -0800, Dmitry Torokhov wrote:
quoted
i2c bus has 2 different types of device belonging to the same bus and
bus notifiers use device type to distinguish between adapters and clients.
Previously we only had i2c_adapter_type exported, which made code wanting
to work with i2c_client devices test for type not equal to adapter type.
This unfortunately is not safe if we ever add another type to the bus,
so let's export i2c_client_type as well.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---

Wolfram, this is the patch I was talking about in the other mail.
I see. From a glimpse, I am fine with the patch. I'll add Jean Delvare
to CC, though, in case I missed some detail he still knows. Furthermore,
while I agree that testing for "not adapter" when one means "is client"
is not nice, is there a bigger benefit than being correct in your queue?
No, just my dislike of testing for "dev->type != &i2c_adapter_type" in
the new i2c bus notifier when we want to work with i2c clients.

Thanks.

-- 
Dmitry
Thread (28 messages) 28 messages, 6 authors, last reply 2017-04-01
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help