Re: [PATCH v2 05/15] HID: logitech-hidpp: forward device info in power_supply
From: Jiri Kosina <jikos@kernel.org>
Date: 2017-03-06 12:18:18
Also in:
lkml
From: Jiri Kosina <jikos@kernel.org>
Date: 2017-03-06 12:18:18
Also in:
lkml
On Tue, 7 Feb 2017, Benjamin Tissoires wrote:
quoted
quoted
+ case POWER_SUPPLY_PROP_MANUFACTURER: + val->strval = "Logitech, Inc.";I don't like this change. I'd prefer the concatenated manufacturer and model strings leading to user-friendly strings, and "Logitech T650" is better than "Logitech, Inc. T650".Is this the only problematic issue? We are at rc7 already so I would like to have the final version ready ASAP.
Bastien, do you have any input on the rest of the series please? Thanks, -- Jiri Kosina SUSE Labs