Thread (13 messages) 13 messages, 6 authors, 2017-03-15

Re: [PATCH v14 3/5] input: touchscreen: mxs-lradc: Add support for touchscreen

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2017-03-01 21:59:53
Also in: linux-iio, lkml

Hi Ksenija,

On Wed, Mar 01, 2017 at 07:02:11PM +0100, Ksenija Stanojevic wrote:
+static int mxs_lradc_ts_register(struct mxs_lradc_ts *ts)
+{
+	struct input_dev *input = ts->ts_input;
+	struct device *dev = ts->dev;
+
+	input = devm_input_allocate_device(dev);
+	if (!input)
+		return -ENOMEM;
+
+	input->name = "mxs-lradc-ts";
+	input->id.bustype = BUS_HOST;
+	input->open = mxs_lradc_ts_open;
+	input->close = mxs_lradc_ts_close;
+
+	__set_bit(EV_ABS, input->evbit);
+	__set_bit(EV_KEY, input->evbit);
+	__set_bit(BTN_TOUCH, input->keybit);
If you end up re-spinnig the series, please drop __set_bit()s above and
replace with

	input_set_capability(input, EV_KEY, BTN_TOUCH);

because input_set_abs_params() already sets EV_ABS for you.

If you will not re-spin, you can leave it as is.

In any case:

Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

+	__set_bit(INPUT_PROP_DIRECT, input->propbit);
+	input_set_abs_params(input, ABS_X, 0, LRADC_SINGLE_SAMPLE_MASK, 0, 0);
+	input_set_abs_params(input, ABS_Y, 0, LRADC_SINGLE_SAMPLE_MASK, 0, 0);
+	input_set_abs_params(input, ABS_PRESSURE, 0, LRADC_SINGLE_SAMPLE_MASK,
+			     0, 0);
+
+	ts->ts_input = input;
+	input_set_drvdata(input, ts);
+
+	return input_register_device(input);
+}
Thanks.

-- 
Dmitry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help