On Thu, Jan 26, 2017 at 2:31 AM, Linus Walleij [off-list ref] wrote:

On Sat, Jan 21, 2017 at 7:45 PM, Guenter Roeck [off-list ref] wrote:

quoted

If a function declares a variable to access a structure element,
use it conssistently.

Weird spelling :)

quoted

Signed-off-by: Guenter Roeck <linux@roeck-us.net>

quoted

-               error = devm_gpio_request_one(&pdev->dev, button->gpio, flags,
-                                             desc);
+               error = devm_gpio_request_one(dev, button->gpio, flags, desc);

I think I have changes in the GPIO tree touching these code sites.

I put those on an immutable branch so Dmitry can pull it if he needs
it as a base for this patch:
https://git.kernel.org/cgit/linux/kernel/git/linusw/linux-gpio.git/commit/?h=ib-gpiod-flags

I just tried it and it seems to merge cleanly even on top of Guenter's
patch so I think I do not have to pull it in, not yet at least.

Thanks.

-- 
Dmitry