Re: [PATCH 04/13] Input: keyboard - Use local variables consistently

From
Linus Walleij <hidden>
Date
2017-01-26 10:31:05
Also in
lkml
Reply to
Guenter Roeck, 2017-01-21
On Sat, Jan 21, 2017 at 7:45 PM, Guenter Roeck [off-list ref] wrote:
If a function declares a variable to access a structure element,
use it conssistently.
Weird spelling :)
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
quoted hunk ↗ jump to hunk
-               error = devm_gpio_request_one(&pdev->dev, button->gpio, flags,
-                                             desc);
+               error = devm_gpio_request_one(dev, button->gpio, flags, desc);
I think I have changes in the GPIO tree touching these code sites.

I put those on an immutable branch so Dmitry can pull it if he needs
it as a base for this patch:
https://git.kernel.org/cgit/linux/kernel/git/linusw/linux-gpio.git/commit/?h=ib-gpiod-flags

Yours,
Linus Walleij
Thread (18 messages) 18 messages, 3 authors, last reply 2017-01-26
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help