Re: [PATCH 0/2] more quirks for hid-sensor-hub

On Nov 28 2016 or thereabouts, Srinivas Pandruvada wrote:

Hi Benjamin,

On Fri, 2016-11-25 at 11:03 +0100, Benjamin Tissoires wrote:

quoted

Hi Jiri,

here are 2 more quirks for the sensor-hub.

Srinivas, I am wondering if we can not detect those automatically.
Looking at the report_fixup, it looks like the buggy report
descriptors have
a logical max of 5 (which would correspond to an enum of 0 to 5). But
there
are 6 fields in the enum, so that means the report descriptor is just
wrong.

Given that Microsoft's driver requires a min of 1, wouldn't it be too
much
assumption to say that we need to fix the report descriptor anyway
when we
see a range of 0..5 instead of 1..6?

The problem is that they should have also changed logical minimum,
which vendors didn't do as Windows driver will always assume
enumeration base as 1.

As far as I can tell there was only Windows platform where base was 0,
but I am sure that Windows update and BIOS update would have fixed that
by now after 3 years.

I am in opinion to change this to match this with Windows driver, so
that we don't need this quirks. This is a small change in IIO sensor
hub driver.

If nobody has objection, I can submit a trivial change for this.

I don't have any objections (I must confess I don't have a lot of these
- 1 maybe 2), and I'd rather get rid of the quirk at all.

Cheers,
Benjamin

Thanks,
Srinivas

quoted

Cheers,
Benjamin

Benjamin Tissoires (2):
  HID: sensor-hub add quirk for Microsoft Surface 3
  HID: sensor-hub: add quirk for Microchip MM7150

 drivers/hid/hid-sensor-hub.c | 6 ++++++
 1 file changed, 6 insertions(+)