Re: [PATCH] Input - elantech: fix debug dump of the current packet

On July 28, 2016 11:58:29 AM PDT, Joe Perches [off-list ref] wrote:

On Thu, 2016-07-28 at 11:54 -0700, Dmitry Torokhov wrote:

quoted

On Thu, Jul 28, 2016 at 11:49:57AM -0700, Joe Perches wrote:

[]

quoted

quoted

So use dev_printk(KERN_DEBUG, etc...

#define psmouse_printk(level, psmouse, format, ...)	\
	dev_printk(level,				\
		   &(psmouse)->ps2dev.serio->dev,	\
		   psmouse_fmt(format), ##__VA_ARGS__)

I want to see current protocol module in th eoutput and I do not want

to

quoted

write "&(psmouse)->ps2dev.serio->dev" all the time.

There are only 2 uses of the macro.

$ git grep psmouse_printk
drivers/input/mouse/elantech.c:                 psmouse_printk(KERN_DEBUG,
psmouse,             \
drivers/input/mouse/elantech.c: psmouse_printk(KERN_DEBUG, psmouse,
"PS/2 packet [");
drivers/input/mouse/psmouse.h:#define psmouse_printk(level, psmouse,
format, ...)       \

Yes, but many more of psmouse_<severity> calls and I like consistency.


Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html