Re: [PATCH] Input - elantech: fix debug dump of the current packet
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2016-07-28 18:22:36
Also in:
lkml
On Thu, Jul 28, 2016 at 11:58:55AM +0200, Benjamin Tissoires wrote:
The use of mixed psmouse_printk() and printk creates 2 lines in the log, while the use of %*ph solves everything. Signed-off-by: Benjamin Tissoires <redacted>
Applied, thank you.
quoted hunk ↗ jump to hunk
--- drivers/input/mouse/elantech.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c index 615d23e..3461d04 100644 --- a/drivers/input/mouse/elantech.c +++ b/drivers/input/mouse/elantech.c@@ -222,12 +222,8 @@ static int elantech_write_reg(struct psmouse *psmouse, unsigned char reg, */ static void elantech_packet_dump(struct psmouse *psmouse) { - int i; - - psmouse_printk(KERN_DEBUG, psmouse, "PS/2 packet ["); - for (i = 0; i < psmouse->pktsize; i++) - printk("%s0x%02x ", i ? ", " : " ", psmouse->packet[i]); - printk("]\n"); + psmouse_printk(KERN_DEBUG, psmouse, "PS/2 packet [%*ph]", + psmouse->pktsize, psmouse->packet); } /*-- 2.5.5
-- Dmitry