Re: [PATCH 2/2] Input-at32psif: Remove OOM messages in psif_probe()
From: Julia Lawall <hidden>
Date: 2016-07-02 19:29:22
Also in:
kernel-janitors, lkml
On Sat, 2 Jul 2016, SF Markus Elfring wrote:
quoted hunk ↗ jump to hunk
From: Markus Elfring <redacted> Date: Sat, 2 Jul 2016 20:34:18 +0200 Delete two debug messages because Linux will usually provide an appropriate information for a memory allocation failure. Signed-off-by: Markus Elfring <redacted> --- drivers/input/serio/at32psif.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)diff --git a/drivers/input/serio/at32psif.c b/drivers/input/serio/at32psif.c index fcb769a..b30503d 100644 --- a/drivers/input/serio/at32psif.c +++ b/drivers/input/serio/at32psif.c@@ -210,15 +210,13 @@ static int __init psif_probe(struct platform_device *pdev) int ret; psif = kzalloc(sizeof(struct psif), GFP_KERNEL); - if (!psif) { - dev_dbg(&pdev->dev, "out of memory\n"); + if (!psif) return -ENOMEM; - } +
Why add a blank line here?
psif->pdev = pdev;
io = kzalloc(sizeof(struct serio), GFP_KERNEL);
if (!io) {
- dev_dbg(&pdev->dev, "out of memory\n");
ret = -ENOMEM;
goto out_free_psif;
}
--
2.9.0