7 messages, 4 authors, 2016-07-13 · open the first message on its own page
From: SF Markus Elfring <hidden>
Date: 2016-07-02 19:00:53
From: Markus Elfring <redacted> Date: Sat, 2 Jul 2016 20:50:09 +0200 A few update suggestions were taken into account from static source code analysis. Markus Elfring (2): Return directly after a failed kzalloc() Remove two OOM messages drivers/input/serio/at32psif.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) -- 2.9.0
From: SF Markus Elfring <hidden>
Date: 2016-07-02 19:05:45
From: Markus Elfring <redacted> Date: Sat, 2 Jul 2016 18:34:43 +0200 Return directly after a memory allocation failed at the beginning. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <redacted> --- drivers/input/serio/at32psif.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/input/serio/at32psif.c b/drivers/input/serio/at32psif.c
index 2e4ff5b..fcb769a 100644
--- a/drivers/input/serio/at32psif.c
+++ b/drivers/input/serio/at32psif.c@@ -212,8 +212,7 @@ static int __init psif_probe(struct platform_device *pdev) psif = kzalloc(sizeof(struct psif), GFP_KERNEL); if (!psif) { dev_dbg(&pdev->dev, "out of memory\n"); - ret = -ENOMEM; - goto out; + return -ENOMEM; } psif->pdev = pdev;
@@ -297,7 +296,6 @@ out_free_io: kfree(io); out_free_psif: kfree(psif); -out: return ret; }
--
2.9.0
From: SF Markus Elfring <hidden>
Date: 2016-07-02 19:07:38
From: Markus Elfring <redacted> Date: Sat, 2 Jul 2016 20:34:18 +0200 Delete two debug messages because Linux will usually provide an appropriate information for a memory allocation failure. Signed-off-by: Markus Elfring <redacted> --- drivers/input/serio/at32psif.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/input/serio/at32psif.c b/drivers/input/serio/at32psif.c
index fcb769a..b30503d 100644
--- a/drivers/input/serio/at32psif.c
+++ b/drivers/input/serio/at32psif.c@@ -210,15 +210,13 @@ static int __init psif_probe(struct platform_device *pdev) int ret; psif = kzalloc(sizeof(struct psif), GFP_KERNEL); - if (!psif) { - dev_dbg(&pdev->dev, "out of memory\n"); + if (!psif) return -ENOMEM; - } + psif->pdev = pdev; io = kzalloc(sizeof(struct serio), GFP_KERNEL); if (!io) { - dev_dbg(&pdev->dev, "out of memory\n"); ret = -ENOMEM; goto out_free_psif; }
--
2.9.0
From: Julia Lawall <hidden>
Date: 2016-07-02 19:29:22
On Sat, 2 Jul 2016, SF Markus Elfring wrote:
From: Markus Elfring <redacted> Date: Sat, 2 Jul 2016 20:34:18 +0200 Delete two debug messages because Linux will usually provide an appropriate information for a memory allocation failure. Signed-off-by: Markus Elfring <redacted> --- drivers/input/serio/at32psif.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)diff --git a/drivers/input/serio/at32psif.c b/drivers/input/serio/at32psif.c index fcb769a..b30503d 100644 --- a/drivers/input/serio/at32psif.c +++ b/drivers/input/serio/at32psif.c@@ -210,15 +210,13 @@ static int __init psif_probe(struct platform_device *pdev) int ret; psif = kzalloc(sizeof(struct psif), GFP_KERNEL); - if (!psif) { - dev_dbg(&pdev->dev, "out of memory\n"); + if (!psif) return -ENOMEM; - } +
Why add a blank line here?
psif->pdev = pdev;
io = kzalloc(sizeof(struct serio), GFP_KERNEL);
if (!io) {
- dev_dbg(&pdev->dev, "out of memory\n");
ret = -ENOMEM;
goto out_free_psif;
}
--
2.9.0
From: Joe Perches <joe@perches.com>
Date: 2016-07-02 20:45:40
On Sat, 2016-07-02 at 21:00 +0200, SF Markus Elfring wrote:
From: Markus Elfring <redacted> Date: Sat, 2 Jul 2016 20:50:09 +0200 A few update suggestions were taken into account from static source code analysis. Markus Elfring (2): Return directly after a failed kzalloc() Remove two OOM messages drivers/input/serio/at32psif.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-)
What possible rationale is there for including this "references" header? 566ABCD9.1060404@users.sourceforge.net This message id is for your message: "Source code review around jump label usage" sent December 11, 2015! Please stop adding unnecessary and useless email headers. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: SF Markus Elfring <hidden>
Date: 2016-07-03 08:02:31
quoted
A few update suggestions were taken into account from static source code analysis. Markus Elfring (2): Return directly after a failed kzalloc() Remove two OOM messages drivers/input/serio/at32psif.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-)What possible rationale is there for including this "references" header? 566ABCD9.1060404@users.sourceforge.net
Do any more software developers dare to reconsider source code also around a jump label like "out"?
This message id is for your message: "Source code review around jump label usage" sent December 11, 2015!
Can such an association with a bit of background information be occasionally useful for clarification of corresponding implementation details? Regards, Markus
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2016-07-13 22:01:13
On Sat, Jul 02, 2016 at 09:00:36PM +0200, SF Markus Elfring wrote:
From: Markus Elfring <redacted> Date: Sat, 2 Jul 2016 20:50:09 +0200 A few update suggestions were taken into account from static source code analysis. Markus Elfring (2): Return directly after a failed kzalloc() Remove two OOM messages
I do not see a compelling reason for taking these... Thanks. -- Dmitry