Re: [PATCH] HID: multitouch: add support for Type Cover Pro 3
flat view
From: Benjamin Tissoires <hidden>
Date: 2016-06-24 07:14:24
On Jun 23 2016 or thereabouts, Dennis Chen wrote:
On Mon, 2016-06-20 at 11:59 +0200, Benjamin Tissoires wrote:quoted
Could you send the dmesg after disconnet/reconnect and some hid-recorder[1] trace after re-attaching the device when the keyboard is not working?I've noticed that the problem resolves itself after a while. Here are the relevant dmseg lines. ---SNIP-- [ 2409.650260] usb 1-3: new full-speed USB device number 16 using xhci_hcd [ 2409.815845] usb 1-3: New USB device found, idVendor=045e, idProduct=07dc [ 2409.815853] usb 1-3: New USB device strings: Mfr=1, Product=2, SerialNumber=3 [ 2409.815858] usb 1-3: Product: Surface Type Cover [ 2409.815861] usb 1-3: Manufacturer: Microsoft [ 2409.815864] usb 1-3: SerialNumber: 041396550454 [ 2419.823679] hid-multitouch 0003:045E:07DC.0012: usb_submit_urb(ctrl) failed: -1 [ 2419.823710] hid-multitouch 0003:045E:07DC.0012: timeout initializing reports [ 2419.824295] input: Microsoft Surface Type Cover Keyboard as /devices/pci0000:00/0000:00:14.0/usb1/1-3/1-3:1.0/0003:045E:07DC.0012/input/input179 [ 2419.875399] input: Microsoft Surface Type Cover Consumer Control as /devices/pci0000:00/0000:00:14.0/usb1/1-3/1-3:1.0/0003:045E:07DC.0012/input/input181 [ 2419.875837] input: Microsoft Surface Type Cover Touchpad as /devices/pci0000:00/0000:00:14.0/usb1/1-3/1-3:1.0/0003:045E:07DC.0012/input/input183 [ 2419.876411] hid-multitouch 0003:045E:07DC.0012: input,hiddev0,hidraw4: USB HID v1.11 Keyboard [Microsoft Surface Type Cover] on usb-0000:00:14.0-3/input0 [ 2419.876641] usb 1-3: USB disconnect, device number 16 [ 2419.934821] hid-multitouch 0003:045E:07DC.0012: usb_submit_urb(ctrl) failed: -19 [ 2420.191569] usb 1-3: new full-speed USB device number 17 using xhci_hcd [ 2420.356899] usb 1-3: New USB device found, idVendor=045e, idProduct=07dc [ 2420.356902] usb 1-3: New USB device strings: Mfr=1, Product=2, SerialNumber=3 [ 2420.356903] usb 1-3: Product: Surface Type Cover [ 2420.356904] usb 1-3: Manufacturer: Microsoft [ 2420.356905] usb 1-3: SerialNumber: 041396550454 [ 2430.361044] hid-multitouch 0003:045E:07DC.0013: usb_submit_urb(ctrl) failed: -1 [ 2430.361072] hid-multitouch 0003:045E:07DC.0013: timeout initializing reports [ 2430.361967] input: Microsoft Surface Type Cover Keyboard as /devices/pci0000:00/0000:00:14.0/usb1/1-3/1-3:1.0/0003:045E:07DC.0013/input/input195 [ 2430.414002] input: Microsoft Surface Type Cover Consumer Control as /devices/pci0000:00/0000:00:14.0/usb1/1-3/1-3:1.0/0003:045E:07DC.0013/input/input197 [ 2430.414356] input: Microsoft Surface Type Cover Touchpad as /devices/pci0000:00/0000:00:14.0/usb1/1-3/1-3:1.0/0003:045E:07DC.0013/input/input199 [ 2430.415114] hid-multitouch 0003:045E:07DC.0013: input,hiddev0,hidraw4: USB HID v1.11 Keyboard [Microsoft Surface Type Cover] on usb-0000:00:14.0-3/input0 [ 2430.415365] usb 1-3: USB disconnect, device number 17 [ 2430.457425] hid-multitouch 0003:045E:07DC.0013: usb_submit_urb(ctrl) failed: -19 [ 2430.714979] usb 1-3: new full-speed USB device number 18 using xhci_hcd [ 2430.880521] usb 1-3: New USB device found, idVendor=045e, idProduct=07dc [ 2430.880528] usb 1-3: New USB device strings: Mfr=1, Product=2, SerialNumber=3 [ 2430.880532] usb 1-3: Product: Surface Type Cover [ 2430.880534] usb 1-3: Manufacturer: Microsoft [ 2430.880537] usb 1-3: SerialNumber: 041396550454 [ 2434.993319] input: Microsoft Surface Type Cover Keyboard as /devices/pci0000:00/0000:00:14.0/usb1/1-3/1-3:1.0/0003:045E:07DC.0014/input/input211 [ 2435.045167] input: Microsoft Surface Type Cover Consumer Control as /devices/pci0000:00/0000:00:14.0/usb1/1-3/1-3:1.0/0003:045E:07DC.0014/input/input213 [ 2435.045506] input: Microsoft Surface Type Cover Touchpad as /devices/pci0000:00/0000:00:14.0/usb1/1-3/1-3:1.0/0003:045E:07DC.0014/input/input215 [ 2435.046174] hid-multitouch 0003:045E:07DC.0014: input,hiddev0,hidraw4: USB HID v1.11 Keyboard [Microsoft Surface Type Cover] on usb-0000:00:14.0-3/input0 ---END--- Hopefully this is helpful. I've looked at the your patch, and - as you've mentioned - have no idea why this only occurs with your patch.
Looks like the same issue Andy is seeing on the Surface Book. So I think my patch must have a bug where it resets the quirks set by usbhid. And this is why we are screwed here. Regarding your disconnect issue, what happens I think is that you disconnect it before the timeout of usb_submit_urb(), and so the usb layer is stuck trying to access the device and can't access the newly plugged one. If you wait enough (initial timeout + new timeout -> 20 secs), then the device behaves properly again. Cheers, Benjamin -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html