Thread (15 messages) 15 messages, 3 authors, 2016-09-19

Re: [PATCH] HID: multitouch: add support for Type Cover Pro 3

flat view

From: Benjamin Tissoires <hidden>
Date: 2016-06-18 19:45:39

On Jun 18 2016 or thereabouts, Dennis Chen wrote:
On Fri, 2016-06-17 at 23:11 +0200, Benjamin Tissoires wrote:
quoted
On Jun 17 2016 or thereabouts, Jiri Kosina wrote:
quoted
This would mean that both hid-multitouch and hid-microsoft would
claim support for this device, which isn't really going to provide
consistent user experience. Is MT_CLS_EXPORT_ALL_INPUTS sufficient
to provide complete functionality by hid-multitouch? If so, the
support from hid-microsoft should be dropped.
I find MT_CLS_EXPORT_ALL_INPUTS to make the Type Cover 3 near
completely functional. I'll send a PATCHv2 to drop hid-microsoft
support. However, hid-microsoft provided Caps-Lock LED control, which
hid-multitouch does not; I'm not sure how to fix this. 
That's the entire purpose of the series I mentioned below. It adds
the keyboard support, caps lock and multitouch, so there is nothing more
to fix once it is in. The benefit is that MT_CLS_EXPORT_ALL_INPUTS
exports far too many input devices while the series exports only the
required ones.
quoted
Also, please see if the series with the 2 following patches is not
sufficient enough:
http://www.spinics.net/lists/linux-input/msg44576.html
http://www.spinics.net/lists/linux-input/msg44577.html

If you just adapt the second patch to add your ids, it should
hopefully be working (though the surface book is not for some unknown
reasons
yet).
I'll test this out sometime this week, and get back to you. 
Thanks.

Cheers,
Benjamin




--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help