Re: [PATCH] Alps I2C HID Touchpad-Stick support

On Mon, 20 Jun 2016, Dmitry Torokhov wrote:

quoted

+struct u1_dev *priv;

I do not understand why you need this global. You can allocate arbitrary
memory in probe() and you actually already do that, why do you need
second copy?

Mea culpa, I raised this concern already quite some time ago, and missed 
the fact that it wasn't fixed in further submissions :/ 

Thanks,

-- 
Jiri Kosina
SUSE Labs