Re: [PATCH] Alps I2C HID Touchpad-Stick support

On Thu, 16 Jun 2016, Masaki Ota wrote:

quoted

From Masaki Ota [off-list ref]

<ChangeList>
- Add hid-alps.c for Support Alps I2C HID Touchpad and Stick device.
- Add hid-alps.txt to check this device spec.
- Add Alps-JP vendor ID to hid-idh.h for support this device. 
- To build this module, add Alps module definition to Makefile.

Signed-off-by: Masaki Ota <redacted>
---
 Documentation/hid/hid-alps.txt | 139 +++++++++++
 drivers/hid/Kconfig            |   8 +
 drivers/hid/Makefile           |   1 +
 drivers/hid/hid-alps.c         | 525 +++++++++++++++++++++++++++++++++++++++++
 drivers/hid/hid-ids.h          |   2 +

You actually also should update hid_have_special_driver[] in hid-core.c to 
make sure that generic driver doesn't override you. Given that I've missed 
this and already applied your patch -- could you please send that as a 
followup patch as well?

Thanks,

-- 
Jiri Kosina
SUSE Labs