Re: [PATCH 5/5] regulator: qcom_rpm-regulator: Add support for pm8018 rpm regulator
flat view
From: Bjorn Andersson <hidden>
Date: 2016-06-17 16:54:03
Also in:
linux-arm-msm, linux-rtc, lkml
On Fri 17 Jun 03:22 PDT 2016, Neil Armstrong wrote:
In order to support eh Qualcomm MDM9615 SoC, add support for the PM8018 RPM regulator in the qcom_rpm-regulator driver. Signed-off-by: Neil Armstrong <narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
[..]
quoted hunk ↗ jump to hunk
diff --git a/drivers/regulator/qcom_rpm-regulator.c b/drivers/regulator/qcom_rpm-regulator.c
[..]
quoted hunk ↗ jump to hunk
+/** + * enum rpm_vreg_voltage_corner - possible voltage corner values + * + * These should be used in regulator_set_voltage and rpm_vreg_set_voltage calls + * for corner type regulators as if they had units of uV. + */ +enum rpm_vreg_voltage_corner { + RPM_VREG_CORNER_NONE = 1, + RPM_VREG_CORNER_LOW, + RPM_VREG_CORNER_NOMINAL, + RPM_VREG_CORNER_HIGH, +}; + +static struct regulator_linear_range corner_ranges[] = { + REGULATOR_LINEAR_RANGE(RPM_VREG_CORNER_NONE, 0, + RPM_VREG_CORNER_HIGH, 1), +}; + static int rpm_reg_write(struct qcom_rpm_reg *vreg,
[..]
quoted hunk ↗ jump to hunk
+ +static const struct qcom_rpm_reg pm8018_corner = { + .desc.linear_ranges = corner_ranges, + .desc.n_linear_ranges = ARRAY_SIZE(corner_ranges), + .desc.n_voltages = 4, + .desc.ops = &uV_ops, + .parts = &rpm8018_corner_parts, +}; +
[..]
+static const struct rpm_regulator_data rpm_pm8018_regulators[] = {[..]
quoted hunk ↗ jump to hunk
+ { "dig_corner", QCOM_RPM_VOLTAGE_CORNER, &pm8018_corner, + "vdd_dig_corner" }, + + { } +};
We have discussed the corners for a long time and I think we've concluded that they should be exposed as something like an OPP. What we have agreed on is that they should not be exposed as a regulator with voltages 1-4uV. So please drop the corner for now. Regards, Bjorn -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout.