Thread (9 messages) 9 messages, 2 authors, 2016-04-05

Re: uinput: ioctls for UI_BEGIN_FF_UPLOAD fails (returns -1). How to debug?

flat view

From: Manuel Reimer <hidden>
Date: 2016-04-05 19:10:20

On 04/03/2016 12:21 PM, Clément VUCHENER wrote:
At line 159 you are passing the address of a stack variable that is no
longer valid when leaving the "if (1)". So the content of rargs may be
overwritten by future stack variable like msg_out in the next loop.
Fix your memory management and you may find out you don't actually
have any problem with uinput.
Exactly! This seems to have resolved my problem. I did several tries and so far no more crashes.

https://github.com/M-Reimer/pspaddrv/commit/effbaae8

Thank you very much for finding this one! I don't think I would have ever found that one and maybe had given up at last...

Now I can continue with some code cleanup, adding the rumble code for PS4 and finally I'll have to find a way to get the common "emulated events" for memoryless devices. One solution would be to try to get ff_memless connected with uinput via kernel patch. I'll give that a try first.

Manuel
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help