Thread (17 messages) 17 messages, 4 authors, 2016-04-27

Re: [PATCH] Input: Do not add SYN_REPORT in between a single packet data

From: Henrik Rydberg <rydberg@bitmath.org>
Date: 2016-03-10 14:01:25
Also in: lkml

Hi Dmitry,
quoted
diff --git a/drivers/input/input.c b/drivers/input/input.c
index 8806059..262ef77 100644
--- a/drivers/input/input.c
+++ b/drivers/input/input.c
@@ -401,8 +401,7 @@ static void input_handle_event(struct input_dev *dev,
                if (dev->num_vals >= 2)
                        input_pass_values(dev, dev->vals, dev->num_vals);
                dev->num_vals = 0;
-       } else if (dev->num_vals >= dev->max_vals - 2) {
-               dev->vals[dev->num_vals++] = input_value_sync;
+       } else if (dev->num_vals >= dev->max_vals - 1) {
                input_pass_values(dev, dev->vals, dev->num_vals);
                dev->num_vals = 0;
        }
This makes sense to me. Henrik?
I went through the commits that made these changes, and I cannot see any strong
reason to keep it. However, this code path only triggers if no SYN events are
seen, as in a driver that fails to emit them and consequently fills up the
buffer. In other words, this change would only affect a device that is already,
to some degree, broken.

So, the question to Aniroop is: do you see this problem in practise, and in that
case, for what driver?

Henrik
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help