Re: [PATCH] Input: Do not add SYN_REPORT in between a single packet data
From: Aniroop Mathur <hidden>
Date: 2016-03-09 18:53:40
Also in:
lkml
Hello Mr. Torokhov, Could you kindly help to update about below patch? Thanks, Aniroop Mathur On Mon, Mar 7, 2016 at 11:14 PM, Aniroop Mathur [off-list ref] wrote:
quoted hunk ↗ jump to hunk
As mentioned in documentation, SYN_REPORT should be used to separate two packets and should not be inserted in between a single packet as otherwise with multiple SYN_REPORT in a single packet, input reader would not be able to know when the packet ended really. Documentation snippet: * SYN_REPORT: - Used to synchronize and separate events into packets of input data changes occurring at the same moment in time. For example, motion of a mouse may set the REL_X and REL_Y values for one motion, then emit a SYN_REPORT. The next motion will emit more REL_X and REL_Y values and send another SYN_REPORT. Signed-off-by: Aniroop Mathur <redacted> --- drivers/input/input.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)diff --git a/drivers/input/input.c b/drivers/input/input.c index 8806059..262ef77 100644 --- a/drivers/input/input.c +++ b/drivers/input/input.c@@ -401,8 +401,7 @@ static void input_handle_event(struct input_dev *dev, if (dev->num_vals >= 2) input_pass_values(dev, dev->vals, dev->num_vals); dev->num_vals = 0; - } else if (dev->num_vals >= dev->max_vals - 2) { - dev->vals[dev->num_vals++] = input_value_sync; + } else if (dev->num_vals >= dev->max_vals - 1) { input_pass_values(dev, dev->vals, dev->num_vals); dev->num_vals = 0; } --2.6.2