Re: [PATCH] Input: input.h: Fix EVIOCSFF macro inconsistency by using _IOW()
From: Dmitry Torokhov <hidden>
Date: 2015-10-15 00:25:25
Also in:
linux-api, lkml
On Thu, Sep 17, 2015 at 07:26:36PM +0200, Elias Vanderstuyft wrote:
Just like the EVIOCSABS(abs) macro, use the more compact _IOW(..., type) instead of _IOC(_IOC_WRITE, ..., sizeof(type)) for the EVIOCSFF macro. Signed-off-by: Elias Vanderstuyft <redacted>
Applied, thank you.
quoted hunk ↗ jump to hunk
--- include/uapi/linux/input.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/include/uapi/linux/input.h b/include/uapi/linux/input.h index 731417c..63915a7 100644 --- a/include/uapi/linux/input.h +++ b/include/uapi/linux/input.h@@ -147,7 +147,7 @@ struct input_keymap_entry { #define EVIOCGABS(abs) _IOR('E', 0x40 + (abs), struct input_absinfo) /* get abs value/limits */ #define EVIOCSABS(abs) _IOW('E', 0xc0 + (abs), struct input_absinfo) /* set abs value/limits */ -#define EVIOCSFF _IOC(_IOC_WRITE, 'E', 0x80, sizeof(struct ff_effect)) /* send a force effect to a force feedback device */ +#define EVIOCSFF _IOW('E', 0x80, struct ff_effect) /* send a force effect to a force feedback device */ #define EVIOCRMFF _IOW('E', 0x81, int) /* Erase a force effect */ #define EVIOCGEFFECTS _IOR('E', 0x84, int) /* Report number of effects playable at the same time */-- 1.9.3
-- Dmitry