Re: [PATCH v1] HID: cp2112: fix byte order in SMBUS operations

On 7/13/2015 7:41 AM, Wolfram Sang wrote:

On Mon, Jul 13, 2015 at 01:23:52PM +0200, Jiri Kosina wrote:

quoted

On Thu, 9 Jul 2015, Ellen Wang wrote:

quoted

Change all occurrences of be16 to le16 in cp2112_xfer(),
because SMBUS words are little endian, not big endian.

Signed-off-by: Ellen Wang <redacted>

Alright, this means that I2C_SMBUS_WORD_DATA and I2C_SMBUS_PROC_CALL have
been terminally broken since the very beginning and noone noticed.

Does this mean that those commands are in practice mostly unused anyway?
This is important for 4.2 vs 4.3 consideration.

PROC_CALL is really rare. WORD_DATA depends on the setup, it is used.

Yes.  WORD_DATA is common.  It's probably become less used since Antonio 
implemented i2c operations.

I think this really means that the device itself is rarely used.  On the 
other hand, for the people who unfortunately have it, these are 
important fixes.