Thread (5 messages) flat view 5 messages, 3 authors, 2015-07-14

Re: [PATCH v1] HID: cp2112: fix byte order in SMBUS operations

From: Wolfram Sang <hidden>
Date: 2015-07-13 14:41:24
Also in: linux-i2c

On Mon, Jul 13, 2015 at 01:23:52PM +0200, Jiri Kosina wrote:
On Thu, 9 Jul 2015, Ellen Wang wrote:
quoted
Change all occurrences of be16 to le16 in cp2112_xfer(),
because SMBUS words are little endian, not big endian.

Signed-off-by: Ellen Wang <redacted>
Alright, this means that I2C_SMBUS_WORD_DATA and I2C_SMBUS_PROC_CALL have 
been terminally broken since the very beginning and noone noticed.

Does this mean that those commands are in practice mostly unused anyway? 
This is important for 4.2 vs 4.3 consideration.
PROC_CALL is really rare. WORD_DATA depends on the setup, it is used.

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help