Re: [PATCH v5 1/6] mfd: fsl imx25 Touchscreen ADC driver

On Tue, 17 Feb 2015, Fabio Estevam wrote:

On Mon, Feb 16, 2015 at 11:38 AM, Lee Jones [off-list ref] wrote:

quoted

quoted

+static int mx25_tsadc_setup_irq(struct platform_device *pdev,
+                             struct mx25_tsadc *tsadc)
+{
+     struct device *dev = &pdev->dev;
+     struct device_node *np = dev->of_node;
+     int irq;
+
+     irq = platform_get_irq(pdev, 0);
+     if (irq < 0) {

What if 0 is returned?

Then  imx25.dtsi would be passing irq=0 for the ADC, which would be
totally wrong.

Exactly, so it should be <=.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html