Thread (6 messages) 6 messages, 4 authors, 2015-02-26

Re: [PATCH v5 1/6] mfd: fsl imx25 Touchscreen ADC driver

From: Fabio Estevam <hidden>
Date: 2015-02-17 18:54:54
Also in: linux-arm-kernel, linux-devicetree, linux-iio

On Mon, Feb 16, 2015 at 11:38 AM, Lee Jones [off-list ref] wrote:
quoted
+static int mx25_tsadc_setup_irq(struct platform_device *pdev,
+                             struct mx25_tsadc *tsadc)
+{
+     struct device *dev = &pdev->dev;
+     struct device_node *np = dev->of_node;
+     int irq;
+
+     irq = platform_get_irq(pdev, 0);
+     if (irq < 0) {
What if 0 is returned?
Then  imx25.dtsi would be passing irq=0 for the ADC, which would be
totally wrong.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help