Re: [PATCH v2 1/2] DT: i2c: Deprecate adi,adxl34x compatible string
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2015-01-15 17:27:04
Also in:
linux-i2c, linux-sh
Possibly related (same subject, not in this thread)
- 2015-05-22 · Re: [PATCH v2 1/2] DT: i2c: Deprecate adi,adxl34x compatible string · Simon Horman <horms@verge.net.au>
- 2015-05-21 · [PATCH v2 1/2] DT: i2c: Deprecate adi,adxl34x compatible string · Geert Uytterhoeven <geert+renesas@glider.be>
- 2015-03-02 · Re: [PATCH v2 1/2] DT: i2c: Deprecate adi,adxl34x compatible string · Laurent Pinchart <hidden>
- 2015-03-02 · Re: [PATCH v2 1/2] DT: i2c: Deprecate adi,adxl34x compatible string · Wolfram Sang <hidden>
- 2015-02-26 · Re: [PATCH v2 1/2] DT: i2c: Deprecate adi,adxl34x compatible string · Laurent Pinchart <laurent.pinchart@ideasonboard.com>
On Thu, Jan 15, 2015 at 06:02:09PM +0100, Wolfram Sang wrote:
On Thu, Jan 15, 2015 at 04:54:14PM +0200, Laurent Pinchart wrote:quoted
DT nodes should use the more specific adi,adxl345 and adi,adxl346 compatible values instead. As the ADXL346 is backward-compatible with the ADXL345, ADXL346 nodes must list both adi,adxl346 and adi,adxl345, in that order. Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> --- Documentation/devicetree/bindings/i2c/trivial-devices.txt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/Documentation/devicetree/bindings/i2c/trivial-devices.txt index 9f41d05be3be..757e42510517 100644 --- a/Documentation/devicetree/bindings/i2c/trivial-devices.txt +++ b/Documentation/devicetree/bindings/i2c/trivial-devices.txt@@ -18,8 +18,7 @@ adi,adt7475 +/-1C TDM Extended Temp Range I.C adi,adt7476 +/-1C TDM Extended Temp Range I.C adi,adt7490 +/-1C TDM Extended Temp Range I.C adi,adxl345 Three-Axis Digital Accelerometer -adi,adxl346 Three-Axis Digital Accelerometer -adi,adxl34x Three-Axis Digital Accelerometer +adi,adxl346 Three-Axis Digital Accelerometer (backward-compatibility value "adi,adxl345" must be listed too)I'd rather drop 346 because there is no compatible for that one anywhere. No need to resend, I can fix it here...
So color me confused now. We deprecated adi,adxl34x because it is generic, but then we adding "specific" adi,adxl345 that covers again both devices? Why do we do this exactly? What is broken at the moment? Thanks. -- Dmitry