Re: [RFC] [Patch] implement video driver for sur40

On 19.12.2014 15:36, Hans Verkuil wrote:

On 12/19/2014 03:30 PM, Florian Echtler wrote:

quoted

Ran the most recent version from git master, got a total of 6 fails, 4
of which are probably easy fixes:

quoted

fail: v4l2-compliance.cpp(306): missing bus_info prefix ('USB:1')
test VIDIOC_QUERYCAP: FAIL

Changed the relevant code to:
  usb_make_path(sur40->usbdev, cap->bus_info, sizeof(cap->bus_info));
	

quoted

fail: v4l2-test-input-output.cpp(455): could set input to invalid input 1
test VIDIOC_G/S/ENUMINPUT: FAIL

Now returning -EINVAL when S_INPUT called with input != 0.

quoted

fail: v4l2-test-formats.cpp(322): !colorspace
fail: v4l2-test-formats.cpp(429): testColorspace(pix.pixelformat,

pix.colorspace, pix.ycbcr_enc, pix.quantization)

quoted

test VIDIOC_G_FMT: FAIL

Setting colorspace in v4l2_pix_format to V4L2_COLORSPACE_SRGB.	

quoted

fail: v4l2-compliance.cpp(365): doioctl(node, VIDIOC_G_PRIORITY, &prio)
test VIDIOC_G/S_PRIORITY: FAIL

Don't know how to fix this - does this mean VIDIOC_G/S_PRIORITY _must_
be implemented?

quoted

fail: v4l2-test-buffers.cpp(500): q.has_expbuf(node)
test VIDIOC_EXPBUF: FAIL

Also not clear how to fix this one.

Could you give some hints on the last two?

Can you post the driver code you used to run these tests? And which kernel version
and git tree did you base your patch on?

Driver code is attached (should be identical to the one from initial
mail). Kernel version used for the tests is 3.16.0-25 from Ubuntu
Utopic, git tree for patches is currently
https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git

I'm building the module standalone on the target machine, since it's not
powerful enough that you would want to do a full kernel build. However,
since the driver was merged into mainline, no other changes have been
made, so I think it shouldn't be a problem to patch against the original
git tree?

Best, Florian
-- 
SENT FROM MY DEC VT50 TERMINAL