Re: [RFC] [Patch] implement video driver for sur40

On 18.12.2014 15:11, Hans Verkuil wrote:

Run as 'v4l2-compliance -s' (-s starts streaming tests as well and it
assumes you have a valid input signal).
Mail if you have any questions about the v4l2-compliance output. The failure
messages expect you to look at the v4l2-compliance source code as well,
but even than it is not always clear what is going on.

Ran the most recent version from git master, got a total of 6 fails, 4
of which are probably easy fixes:

fail: v4l2-compliance.cpp(306): missing bus_info prefix ('USB:1')
test VIDIOC_QUERYCAP: FAIL

Changed the relevant code to:
  usb_make_path(sur40->usbdev, cap->bus_info, sizeof(cap->bus_info));
	

fail: v4l2-test-input-output.cpp(455): could set input to invalid input 1
test VIDIOC_G/S/ENUMINPUT: FAIL

Now returning -EINVAL when S_INPUT called with input != 0.

fail: v4l2-test-formats.cpp(322): !colorspace
fail: v4l2-test-formats.cpp(429): testColorspace(pix.pixelformat,

pix.colorspace, pix.ycbcr_enc, pix.quantization)

test VIDIOC_G_FMT: FAIL

Setting colorspace in v4l2_pix_format to V4L2_COLORSPACE_SRGB.	

fail: v4l2-compliance.cpp(365): doioctl(node, VIDIOC_G_PRIORITY, &prio)
test VIDIOC_G/S_PRIORITY: FAIL

Don't know how to fix this - does this mean VIDIOC_G/S_PRIORITY _must_
be implemented?

fail: v4l2-test-buffers.cpp(500): q.has_expbuf(node)
test VIDIOC_EXPBUF: FAIL

Also not clear how to fix this one.

Could you give some hints on the last two?

Thanks & best regards, Florian
-- 
SENT FROM MY DEC VT50 TERMINAL