Hi Dmitry,

Yes, we intend to do this. Could you help to keep the original code, thank you.

Duson 


Dmitry Torokhov [off-list ref] 於 2014/7/26 上午4:06 寫道：

On Fri, Jul 25, 2014 at 11:20:53AM -0700, Dmitry Torokhov wrote:

quoted

Hi Duson,

On Sat, Jul 26, 2014 at 02:05:02AM +0800, cheng wei Lin wrote:

quoted

Hi Dmitry,

Sorry for late to reply you and thanks for your command

Yes, I also agree, it looks great than my original code.

Thank you for confirming.

quoted

So, should I modify this and upstream v3 patch for you?

No, that is fine, I'll fix it up on my end.

Hmm, I am also looking at elan_get_x_resolution() and in case of SMB
we'll never get negative result since we are doing
"elan_convert_res(val[1] & 0x0F)". Was it intended as such, or do we
need to extend sign here via

	(((char)(val[1] & 0x0F)) << 4) >> 4;

Thanks.

-- 
Dmitry

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html