Re: [PATCH v4 2/2] elantech: Call psmouse_reset when elantech probe fails
From: Hans de Goede <hidden>
Date: 2014-06-17 06:08:44
Hi, On 06/16/2014 11:53 PM, Ulrik De Bie wrote:
elantech_init() calls elantech_set_absolute_mode which sets the driver in an absolute mode. When after this the elantech_init fails, it is best to turn the ps/2 mouse emulation mode back on by calling psmouse_reset() so that it can work as a regular mouse. Signed-off-by: Ulrik De Bie <redacted>
Looks good, this patch is: Reviewed-by: Hans de Goede <redacted> Regards, Hans
quoted hunk ↗ jump to hunk
--- drivers/input/mouse/elantech.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c index 5dd620a..771291c 100644 --- a/drivers/input/mouse/elantech.c +++ b/drivers/input/mouse/elantech.c@@ -1620,6 +1620,7 @@ int elantech_init(struct psmouse *psmouse) sysfs_remove_group(&psmouse->ps2dev.serio->dev.kobj, &elantech_attr_group); init_fail: + psmouse_reset(psmouse); kfree(etd); return error; }