Re: [PATCH v3 2/2] elantech: Call psmouse_reset when elantech probe fails
From: David Herrmann <hidden>
Date: 2014-06-16 08:44:06
Hi On Fri, Jun 13, 2014 at 11:21 PM, Ulrik De Bie [off-list ref] wrote:
Signed-off-by: Ulrik De Bie <redacted>
This patch lacks _any_ explanation why this is done. Please always write commit-messages! It is totally unclear from the patch description why the device is reset. Thanks David
quoted hunk ↗ jump to hunk
--- drivers/input/mouse/elantech.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c index 0eb185b..fa150d9 100644 --- a/drivers/input/mouse/elantech.c +++ b/drivers/input/mouse/elantech.c@@ -1617,6 +1617,7 @@ int elantech_init(struct psmouse *psmouse) sysfs_remove_group(&psmouse->ps2dev.serio->dev.kobj, &elantech_attr_group); init_fail: + psmouse_reset(psmouse); kfree(etd); return error; } --2.0.0