On Tue, May 6, 2014 at 12:51 AM, Maxime Ripard
[off-list ref] wrote:

On Sat, May 03, 2014 at 02:21:06PM +0200, Carlo Caione wrote:

quoted

On Sat, May 3, 2014 at 3:09 AM, Maxime Ripard
[off-list ref] wrote:

quoted

Hi,

On Thu, May 01, 2014 at 02:29:34PM +0200, Carlo Caione wrote:

quoted

Signed-off-by: Hans de Goede <redacted>
Signed-off-by: Carlo Caione <redacted>
---
 arch/arm/boot/dts/sun4i-a10-a1000.dts           | 58 ++++++++++++++++++++++
 arch/arm/boot/dts/sun4i-a10-cubieboard.dts      | 58 ++++++++++++++++++++++
 arch/arm/boot/dts/sun4i-a10-hackberry.dts       | 64 ++++++++++++++++++++++++
 arch/arm/boot/dts/sun4i-a10-inet97fv2.dts       | 58 ++++++++++++++++++++++
 arch/arm/boot/dts/sun4i-a10-mini-xplus.dts      | 65 +++++++++++++++++++++++++
 arch/arm/boot/dts/sun4i-a10-olinuxino-lime.dts  | 64 ++++++++++++++++++++++++
 arch/arm/boot/dts/sun4i-a10-pcduino.dts         | 58 ++++++++++++++++++++++
 arch/arm/boot/dts/sun7i-a20-cubieboard2.dts     | 59 ++++++++++++++++++++++
 arch/arm/boot/dts/sun7i-a20-cubietruck.dts      | 59 ++++++++++++++++++++++
 arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts | 59 ++++++++++++++++++++++
 10 files changed, 602 insertions(+)

diff --git a/arch/arm/boot/dts/sun4i-a10-a1000.dts b/arch/arm/boot/dts/sun4i-a10-a1000.dts
index fa746aea..57d3fb4 100644
--- a/arch/arm/boot/dts/sun4i-a10-a1000.dts
+++ b/arch/arm/boot/dts/sun4i-a10-a1000.dts

@@ -88,6 +88,56 @@
                      pinctrl-names = "default";
                      pinctrl-0 = <&i2c0_pins_a>;
                      status = "okay";
+
+                     axp209: pmic@34 {
+                             compatible = "x-powers,axp209";
+                             reg = <0x34>;
+                             interrupts = <0>;
+
+                             interrupt-controller;
+                             #interrupt-cells = <1>;
+
+                             acin-supply = <&reg_axp_ipsout>;
+                             vin2-supply = <&reg_axp_ipsout>;
+                             vin3-supply = <&reg_axp_ipsout>;
+                             ldo24in-supply = <&reg_axp_ipsout>;
+                             ldo3in-supply = <&reg_axp_ipsout>;
+                             ldo5in-supply = <&reg_axp_ipsout>;
+
+                             regulators {
+                                     x-powers,dcdc-freq = <1500>;
+
+                                     axp_vcore_reg: dcdc2 {
+                                             regulator-min-microvolt = <700000>;
+                                             regulator-max-microvolt = <2275000>;
+                                             regulator-always-on;
+                                     };
+
+                                     axp_ddr_reg: dcdc3 {
+                                             regulator-always-on;
+                                     };
+
+                                     axp_rtc_reg: ldo1 {
+                                             regulator-always-on;
+                                     };
+
+                                     axp_analog_reg: ldo2 {
+                                             regulator-always-on;
+                                     };
+
+                                     axp_pll_reg: ldo3 {
+                                             regulator-always-on;
+                                     };
+
+                                     axp_hdmi_reg: ldo4 {
+                                             regulator-always-on;
+                                     };
+
+                                     axp_mic_reg: ldo5 {
+                                             regulator-always-on;

Do all these regulators need to be always on? It makes sense for the
pll and vcore, but I don't get why the mic and hdmi regulators need
this.

I did this way because I don't have the schematics for all the board
so I thought it was safer to leave all the regulators enabled

Well, we have the schematics for most of these boards (at least all
the cubie and olinuxinos).

As far as the other boards are concerned, if we don't have that
information, I'd say leave them alone until someone has access to
these informations.

What do you mean exactly with "leave them alone". The problem is that
if the regulator is not explicitly marked as always-on, it is disabled
at boot time, so I think that the most safe thing to do is leave them
on to avoid turning off something at boot time that could be
important.

-- 
Carlo Caione