Thread (32 messages) 32 messages, 6 authors, 2014-03-28

Re: [PATCHv4 2/5] Input: edt-ft5x06: Add DT support

From: Mark Rutland <mark.rutland@arm.com>
Date: 2014-03-20 13:19:15
Also in: linux-devicetree, lkml

On Thu, Mar 20, 2014 at 11:18:10AM +0000, Simon Budig wrote:
On 20/03/14 10:37, Mark Rutland wrote:
quoted
On Wed, Mar 19, 2014 at 01:09:20PM +0000, Lothar Waßmann wrote:
quoted
+FocalTech EDT-FT5x06 Polytouch driver
+=====================================
+
+Required properties:
+ - compatible:  "edt,edt-ft5x06"
Is the 'x' part of a particular product name, or is this a class of
devices?
The driver is intended for the EDT "polytouch" family touches, which are
based on a focaltec controller. The current line of touches uses e.g.
the ft5306 as well as the ft5406 focaltec controller.
Ok. The name of the driver and the strings used in DT bindings don't
have to be the same. The bindings strings should describe the hardware
as accurately as possible.
quoted
It's preferable to have a specific string which another similar variants
can claim compatibility with (while also additionally having a more
specific string), as this makes it possible to handle variants more
specially in future, target workarounds, etc.
I chose the driver name since I wanted to differentiate from other EDT
touches, which used a different controller. With hindsight it was
unfortunately confusing, since I get quite some request from people, who
also have a device based on the focaltec controllers, but with a very
different firmware (and communication protocol). They got tricked into
thinking that this driver would be suitable...

If I were to chose the name again I'd probably pick "edt-polytouch" or
something like this. But I doubt that it is useful to change the name now.
I'm not arguing to rename the driver. All I want are the compatible
strings to be as specific as possible.

Cheers,
Mark.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help