Re: [PATCH 1/5] drivers: input: keyboard: st-keyscan: add keyscan driver
From: Lee Jones <hidden>
Date: 2014-03-18 11:01:34
Also in:
linux-arm-kernel, linux-devicetree, lkml
From: Lee Jones <hidden>
Date: 2014-03-18 11:01:34
Also in:
linux-arm-kernel, linux-devicetree, lkml
quoted
quoted
quoted
Sorry for the delay. It was a hectic week last week. As promised:quoted
This patch adds ST Keyscan driver to use the keypad hw a subset of ST boards provide. Specific board setup will be put in the given dt. Signed-off-by: Giuseppe Condorelli<redacted> Signed-off-by: Gabriel Fernandez<redacted>Are you sure these are in the correct order?ok i change the orderI'm not saying they are in the wrong order, I'm just asking. Who wrote the patch? Has it changed since?Sorry... I wrote the patch, then Guiseppe has changed and tested, and I re-modifiedit
Ah, then it starts to get very complicated. :) If you wrote the patch, you need to be at the top of the list. <snip>
quoted
quoted
quoted
+keyscan: keyscan@fe4b0000 { + compatible = "st,keypad"; Is there any way we can make this more specific to _this_ IP?for my knowledge this IP is the same for stixxxx platform.So st,stix-keypad, or st,sti4x-keypad? I'm just thinking about future proofing the architecture. What if ST released stj which has a different keypad IP?After discussing internally with st "st,sti-keyscan" is better
Perfect. <snip> -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog