Thread (21 messages) 21 messages, 3 authors, 2014-03-18

Re: [PATCH 1/5] drivers: input: keyboard: st-keyscan: add keyscan driver

From: Lee Jones <hidden>
Date: 2014-03-10 16:36:08
Also in: linux-arm-kernel, linux-devicetree, lkml

quoted
quoted
quoted
quoted
This patch adds ST Keyscan driver to use the keypad hw a subset
of ST boards provide. Specific board setup will be put in the
given dt.

Signed-off-by: Giuseppe Condorelli <redacted>
Signed-off-by: Gabriel Fernandez <redacted>
Are you sure these are in the correct order?

What is the history of this commit?
quoted
---
 .../devicetree/bindings/input/st-keypad.txt        |  50 ++++
This should be submitted as a seperate patch.
Why do we have such requirement? To me it would make more sense to add
binding documentation in the same commit as the code that uses these
bindings.
I'm inclined to agree with you and that's actually how we used to do
it, but a decision was made by the DT guys at one of the Kernel
Summits to submit Documentation as a separate patch.
Do you have background for this decision? To me it is akin splitting
header file into a separate patch.
The discussion/decision was verbal unfortunately.

I don't really mind either way. I'm just attempting to enforce the
decisions that were made by the forces-that-be. Perhaps ping
devicetree@vger.kernel.org with me in CC for more clarification if
required.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help