Re: Re: [PATCH 3/4] ARM: dts: sun5i: Add lradc node

Hi,

On 01/01/2014 08:45 PM, Andrew Lunn wrote:

On Wed, Jan 01, 2014 at 08:30:09PM +0100, Hans de Goede wrote:

quoted

Signed-off-by: Hans de Goede <redacted>
---
  arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts | 7 +++++++
  arch/arm/boot/dts/sun5i-a10s.dtsi                | 7 +++++++
  arch/arm/boot/dts/sun5i-a13-olinuxino.dts        | 7 +++++++
  arch/arm/boot/dts/sun5i-a13.dtsi                 | 7 +++++++
  4 files changed, 28 insertions(+)

diff --git a/arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts b/arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts
index e53fb12..c32162e 100644
--- a/arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts
+++ b/arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts

@@ -75,6 +75,13 @@
  			};
  		};

+		lradc: lradc@01c22800 {
+			allwinner,chan0-step = <200>;
+			/* KEY_VOLUMEUP VOLUMEDOWN MENU ENTER HOME */
+			allwinner,chan0-keycodes = <115 114 139 28 102>;

Hi Hans

You might want to consider using arch/arm/boot/dts/include/dt-bindings/input/input.h

and then you could have the node:

quoted

+		lradc: lradc@01c22800 {
+			allwinner,chan0-step = <200>;
+			allwinner,chan0-keycodes = <KEY_VOLUMEUP VOLUMEDOWN MENU ENTER HOME>;

which is much more readable.

Ah, I did not know about that include. Good tip, will fix this in v2.

Regards,

Hans