Re: [PATCH 4/8] input: Remove OOM message after input_allocate_device
From: Uwe Kleine-König <hidden>
Date: 2013-10-24 19:16:11
Also in:
linux-arm-kernel, linux-samsung-soc, lkml
On Thu, Oct 24, 2013 at 11:48:48AM -0700, Joe Perches wrote:
On Thu, 2013-10-24 at 20:46 +0200, Uwe Kleine-König wrote:quoted
On Thu, Oct 24, 2013 at 11:43:38AM -0700, Joe Perches wrote:[]quoted
quoted
Any k.alloc without __GFP_NOWARN does a generic OOM message and a dump_stack() so there could already be 2 messages anyway.Then mention that in the commit log if you still want this patch?!How do you think this commit message should be changed: Emitting an OOM message isn't necessary after input_allocate_device as there's a generic OOM and a dump_stack already done.
after input_allocate_device and/or k.alloc ... Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |