Re: [PATCH 4/8] input: Remove OOM message after input_allocate_device
From: Uwe Kleine-König <hidden>
Date: 2013-10-24 18:26:28
Also in:
linux-arm-kernel, linux-samsung-soc, lkml
Hello Joe, On Wed, Oct 23, 2013 at 12:14:50PM -0700, Joe Perches wrote:
quoted hunk ↗ jump to hunk
Emitting an OOM message isn't necessary after input_allocate_device as there's a generic OOM and a dump_stack already done. [...] Signed-off-by: Joe Perches <joe@perches.com>diff --git a/drivers/input/joystick/as5011.c b/drivers/input/joystick/as5011.c index 005d852..3b9c709 100644 --- a/drivers/input/joystick/as5011.c +++ b/drivers/input/joystick/as5011.c@@ -254,8 +254,6 @@ static int as5011_probe(struct i2c_client *client, as5011 = kmalloc(sizeof(struct as5011_device), GFP_KERNEL); input_dev = input_allocate_device(); if (!as5011 || !input_dev) { - dev_err(&client->dev, - "Can't allocate memory for device structure\n");
Don't know if that can happen, but if as5011 is NULL but input_dev isn't the message would still be sensible, wouldn't it? There are several more that suffer the same "problem". Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |