Thread (7 messages) 7 messages, 3 authors, 2013-09-23

RE: [PATCH V2 1/1] Drivers: input: serio: New driver to support Hyper-V synthetic keyboard

From: KY Srinivasan <kys@microsoft.com>
Date: 2013-09-19 16:31:49
Also in: lkml

-----Original Message-----
From: Dmitry Torokhov [mailto:dmitry.torokhov@gmail.com]
Sent: Thursday, September 19, 2013 8:53 AM
To: KY Srinivasan
Cc: gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org;
devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com;
jasowang@redhat.com; dan.carpenter@oracle.com; linux-
input@vger.kernel.org; vojtech@suse.cz
Subject: Re: [PATCH V2 1/1] Drivers: input: serio: New driver to support Hyper-V
synthetic keyboard

On Wed, Sep 18, 2013 at 11:27:51PM +0000, KY Srinivasan wrote:
quoted
quoted
-----Original Message-----
From: Dmitry Torokhov [mailto:dmitry.torokhov@gmail.com]
Sent: Wednesday, September 18, 2013 2:01 PM
To: KY Srinivasan
Cc: gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org;
devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com;
jasowang@redhat.com; dan.carpenter@oracle.com; linux-
input@vger.kernel.org; vojtech@suse.cz
Subject: Re: [PATCH V2 1/1] Drivers: input: serio: New driver to support
Hyper-V
quoted
quoted
synthetic keyboard

Hi K.Y.,

On Tue, Sep 17, 2013 at 04:26:58PM -0700, K. Y. Srinivasan wrote:
quoted
Add a new driver to support synthetic keyboard. On the next generation
Hyper-V guest firmware, many legacy devices will not be emulated and this
driver will be required.

I would like to thank Vojtech Pavlik [off-list ref] for helping me with
the
quoted
quoted
quoted
details of the AT keyboard driver. I would also like to thank
Dan Carpenter [off-list ref] and
Dmitry Torokhov [off-list ref] for their detailed review of
this
quoted
driver.

I have addressed all the comments of Dan and Dmitry in this version of
the patch
This looks much better. Could you tell me if the patch below (on top of
yours) still works?

Thanks.
Thank you. The code looks much better now. You forgot to initialize the
port_data and
quoted
after I fixed that everything seems to work as it did before: Here is the patch I
used:

Excellent, thank you for trying it out. I folded it all together and
queued for 3.13.
Thank you.

Regards,

K. Y
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help