RE: [PATCH V2 1/1] Drivers: input: serio: New driver to support Hyper-V synthetic keyboard
From: KY Srinivasan <kys@microsoft.com>
Date: 2013-09-18 23:28:15
Also in:
lkml
-----Original Message----- From: Dmitry Torokhov [mailto:dmitry.torokhov@gmail.com] Sent: Wednesday, September 18, 2013 2:01 PM To: KY Srinivasan Cc: gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org; devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com; jasowang@redhat.com; dan.carpenter@oracle.com; linux- input@vger.kernel.org; vojtech@suse.cz Subject: Re: [PATCH V2 1/1] Drivers: input: serio: New driver to support Hyper-V synthetic keyboard Hi K.Y., On Tue, Sep 17, 2013 at 04:26:58PM -0700, K. Y. Srinivasan wrote:quoted
Add a new driver to support synthetic keyboard. On the next generation Hyper-V guest firmware, many legacy devices will not be emulated and this driver will be required. I would like to thank Vojtech Pavlik [off-list ref] for helping me with the details of the AT keyboard driver. I would also like to thank Dan Carpenter [off-list ref] and Dmitry Torokhov [off-list ref] for their detailed review ofthisquoted
driver. I have addressed all the comments of Dan and Dmitry in this version of the patchThis looks much better. Could you tell me if the patch below (on top of yours) still works? Thanks.
Thank you. The code looks much better now. You forgot to initialize the port_data and after I fixed that everything seems to work as it did before: Here is the patch I used:
quoted hunk ↗ jump to hunk
-----Original Message----- From: K. Y. Srinivasan [mailto:kys@microsoft.com] Sent: Wednesday, September 18, 2013 4:50 PM To: KY Srinivasan Subject: [PATCH 1/1] Drivers: input: serio: hyper-V: Initialize the port data correctly Signed-off-by: K. Y. Srinivasan <kys@microsoft.com> --- drivers/input/serio/hyperv-keyboard.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)diff --git a/drivers/input/serio/hyperv-keyboard.c b/drivers/input/serio/hyperv-keyboard.c index 401fbdd..aff4152 100644--- a/drivers/input/serio/hyperv-keyboard.c +++ b/drivers/input/serio/hyperv-keyboard.c@@ -351,6 +351,7 @@ static int hv_kbd_probe(struct hv_device *hv_dev, hv_serio->dev.parent = &hv_dev->device; hv_serio->id.type = SERIO_8042_XL; + hv_serio->port_data = kbd_dev; strlcpy(hv_serio->name, dev_name(&hv_dev->device), sizeof(hv_serio->name)); strlcpy(hv_serio->phys, dev_name(&hv_dev->device), --1.7.4.1
Once again; thank you for all your help. Regards, K. Y