Re: [11/51] Input: atmel_mxt_ts - Implement CRC check for configuration data
From: Martin Fuzzey <hidden>
Date: 2013-09-18 17:29:36
Also in:
lkml
From: Martin Fuzzey <hidden>
Date: 2013-09-18 17:29:36
Also in:
lkml
On 27/06/13 14:48, Nick Dyer wrote:
The configuration is stored in NVRAM on the maXTouch chip. When the device is
reset it reports a CRC of the stored configuration values. Therefore it isn't
necessary to send the configuration on each probe - we can check the CRC
matches and avoid a timeconsuming backup/reset cycle.
Signed-off-by: Nick Dyer <redacted>
Acked-by: Benson Leung <bleung@chromium.org>
-static unsigned mxt_extract_T6_csum(const u8 *csum)
+static u16 mxt_extract_T6_csum(const u8 *csum)
{
return csum[0] | (csum[1] << 8) | (csum[2] << 16);
}Shouldn't this be u32? It's losing data causing the checksums not to match for me.